Pluggable transfers and multipart transfer implementation #604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
mesemus
force-pushed
the
contribution-multipart-transfer
branch
from
a878a3c to
378236c
Compare
mesemus
added a commit
to oarepo/invenio-rdm-records
that referenced
this pull request
Jan 19, 2025
* IfFileIsLocal is not used anymore as it was handling just one type of transport * Switched to IfTransferType permission generators * Note: needs inveniosoftware/invenio-records-resources#604
Draft
10 tasks
|
Connected pull requests: RFC 0072 |
This was referenced Jan 19, 2025
invenio_records_resources/proxies.py
Outdated
| @@ -21,3 +31,7 @@ | |||
| lambda: current_app.extensions["invenio-records-resources"].notification_registry | |||
| ) | |||
| """Helper proxy to get the current notifications registry.""" | |||
|
|
|||
| current_transfer_registry: "TransferRegistry" = LocalProxy( | |||
There was a problem hiding this comment.
normally invenio does not add type checks. to be consistent with the rest of invenio i would remove : "TransferRegistry"
There was a problem hiding this comment.
and i saw there are a lot of type hints in other files too
* Implementation of RFC 0072 - Pluggable Transfer Types for Record Files * Pluggable transfer types in invenio_records_resources/services/files/transfers * Implementation of multipart transfer in the same place * Permission generator for per-transfer-type permissions Co-authored-by: Mirek Simek <[email protected]>
mesemus
force-pushed
the
contribution-multipart-transfer
branch
from
378236c to
29f5365
Compare
mesemus
added a commit
to oarepo/invenio-drafts-resources
that referenced
this pull request
Jan 21, 2025
* Implementation of RFC 0072 - Pluggable Transfer Types for Record Files * Needs inveniosoftware/invenio-records-resources#604
10 tasks
mesemus
added a commit
to oarepo/invenio-drafts-resources
that referenced
this pull request
Jan 21, 2025
* Implementation of RFC 0072 - Pluggable Transfer Types for Record Files * Needs inveniosoftware/invenio-records-resources#604
oarepo-bot
pushed a commit
to oarepo/invenio-drafts-resources
that referenced
this pull request
Jan 22, 2025
* Implementation of RFC 0072 - Pluggable Transfer Types for Record Files * Needs inveniosoftware/invenio-records-resources#604
mesemus
added a commit
to oarepo/invenio-rdm-records
that referenced
this pull request
Jan 23, 2025
* IfFileIsLocal is not used anymore as it was handling just one type of transport * Switched to IfTransferType permission generators * Note: needs inveniosoftware/invenio-records-resources#604
oarepo-bot
pushed a commit
to oarepo/invenio-rdm-records
that referenced
this pull request
Jan 23, 2025
* IfFileIsLocal is not used anymore as it was handling just one type of transport * Switched to IfTransferType permission generators * Note: needs inveniosoftware/invenio-records-resources#604
oarepo-bot
pushed a commit
to oarepo/invenio-drafts-resources
that referenced
this pull request
Feb 3, 2025
* Implementation of RFC 0072 - Pluggable Transfer Types for Record Files * Needs inveniosoftware/invenio-records-resources#604
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements RFC 0072—Pluggable Transfer Types for Record Files. It provides transfer classes for all the built-in transfers, a transfer registry, and a transfer-type-aware permission generator.
This PR should be merged together with similar PRs for invenio-rdm-records, invenio-s3, and docs-invenio-rdm.
Checklist
Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:
Frontend
Reminder
By using GitHub, you have already agreed to the GitHub’s Terms of Service including that: